fix: Format gat commands #1312
Merged
fix: Format gat commands #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlaurin
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
simi and
xuan-cao-swi
as code owners
robertlaurin
force-pushed
the
fix-dalli-gat
branch
from
97264dd to
1e84858
Compare
plantfansam
approved these changes
Dec 19, 2024
ericmustin
approved these changes
Dec 19, 2024
fbogsany
requested changes
Dec 20, 2024
Contributor
fbogsany
left a comment
fbogsany
left a comment
There was a problem hiding this comment.
Looks like gat isn't supported in (one of?) the dalli version we test against. We should consider whether to bump the minimum version we support.
fbogsany
reviewed
Dec 20, 2024
| end | ||
|
|
||
| it 'supports gat' do | ||
| dalli.gat('foo') |
Contributor
There was a problem hiding this comment.
gat was added to dalli in 3.0.0. We could skip if the dalli version is < 3.0.0 or set 3.0.0 as the min supported version.
Contributor
There was a problem hiding this comment.
My preference is to skip, since we only need it in this test, and the test matrix should cover 3.0.0.
fbogsany
reviewed
Jan 7, 2025
| end | ||
|
|
||
| it 'supports gat' do | ||
| dalli.gat('foo') |
Contributor
There was a problem hiding this comment.
Suggested change
| dalli.gat('foo') | |
| skip unless dalli.respond_to?(:gat) | |
| dalli.gat('foo') |
Co-authored-by: Francis Bogsanyi <[email protected]>
kaylareopelle
approved these changes
Jan 11, 2025
fbogsany
approved these changes
Jan 14, 2025
This was referenced Jan 14, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't know how to format gat, lets help the instrumentation do it properly.